shaobojohn / adwhirl

Automatically exported from code.google.com/p/adwhirl
0 stars 0 forks source link

iOS 6 support #318

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. install Xcode 4.5 Beta
2. install iOS6 SDK Beta
3. implement AdWhirl

There were already many @deprecated-warnings wbhile compiling adWhirl in iOS5. 
But now with the new iOS6-compiler it throws errors so that it is not possible 
to implement the given adwhirl SDK for objective-c.
When is the iOS6 adwhirl-SDK being released?
Thanks in advance
Fabian

PS the main problem is in AdWhirlAdapterIAd.m

Original issue reported on code.google.com by fhe...@oopdev.de on 13 Jun 2012 at 11:31

GoogleCodeExporter commented 9 years ago
I can confirm this is happening in the new iOS6

They've removed the following constants:

ADBannerContentSizeIdentifierPortrait
ADBannerContentSizeIdentifierLandscape
ADBannerContentSizeIdentifier480x32
ADBannerContentSizeIdentifier320x50

and there is no longer a property 'currentContentSizeIdentifier' on the 
ADBannerView

Each of which is causing compile errors in the file AdWhirlAdapterIAd.m, 
methods getAd and rotateToOrientation

I am currently attempting to correct the problem myself, will let you know how 
it goes.

Original comment by andrew.d...@gmail.com on 15 Jun 2012 at 5:43

GoogleCodeExporter commented 9 years ago
Found a way around it, for now

Add the following import to the top of the ADWhirlAdapterIAd.m file:

#import <iAd/ADBannerView_Deprecated.h>

The system will then run properly, but you get the deprecated warnings.  With 
Apple removing the constants completely in iOS 6, there doesn't seem to be an 
easy way to cover both except using the deprecated constants. Hopefully when 
the new version is fully released, they'll have added backwards compatibility 
in there, because I can get it to compile with 4.3-5.1.1 or 6, but I cannot get 
it to compile for both without resorting to the deprecated constants.

Original comment by andrew.d...@gmail.com on 15 Jun 2012 at 10:42

GoogleCodeExporter commented 9 years ago
hm, I just tried to implement this, but I can not find the 
ADBannerView_Deprecated.h. It is not included in my iAd-Packet.
Where did you get this from? Not from the regular iAd-Framework?

By the way, I think it is time for Google / AdWhirl to reengineer a new SDK for 
iOS. The current one does not even support ARC and all these warnings are 
making things slow...

Regards,
Fabi

Original comment by rechn...@oopdev.de on 19 Jun 2012 at 9:44

GoogleCodeExporter commented 9 years ago
I can confirm that the '#import <iAd/ADBannerView_Deprecated.h>' line made the 
errors go away for me too. Thanks. Would prefer the sdk was updated to fix the 
issue properly though.

Original comment by andrewg...@gmail.com on 20 Jun 2012 at 9:16

GoogleCodeExporter commented 9 years ago
hm, I still can't find this file ADBannerView_Deprecated.h in the 
iAd-framework. And Xcode also throws the error "file not found" when I try to 
import it. 
Which Framework do I have to include to get this file?
Thanks
Fabi

Original comment by rechn...@oopdev.de on 20 Jun 2012 at 10:16

GoogleCodeExporter commented 9 years ago
Its just part of the iAd framework for me.
See attachment, or link: http://i47.tinypic.com/24yb8n7.png

Original comment by andrewg...@gmail.com on 21 Jun 2012 at 10:01

Attachments:

GoogleCodeExporter commented 9 years ago
The errors did gone away, but seems can not get ad on iOS6. I aways get this 
error:

Failed to receive ad from adapter: Error Domain=ADErrorDomain Code=0 "The 
operation couldn’t be completed. Unknown error" UserInfo=0x9d9ca40 
{ADInternalErrorCode=0, ADInternalErrorDomain=ADErrorDomain, 
NSLocalizedFailureReason=Unknown error}

Original comment by ZhaoPeng...@gmail.com on 21 Sep 2012 at 3:25

GoogleCodeExporter commented 9 years ago
#import <iAd/ADBannerView_Deprecated.h>  works for me. Thank you!

Original comment by shakirov...@gmail.com on 22 Sep 2012 at 1:25

GoogleCodeExporter commented 9 years ago
Errors went away, but are you getting any iAds via AdWhirl on iOS6? Since this 
appears to be some sort of a global problem (ref. Apple's dev forums and 
iphonedevsdk.com), but s it iAd + iOS6 in general or just AdWhirl+iOS6+iAd? And 
perhaps especially when dealing with "hardcoded" landscape/portrait mode 
banners..?

Just wondering, if I should just toss the AdWhirl away and go with Admob 
mediation. Although I don't trust the latter one too much yet.

Original comment by mikko...@gmail.com on 22 Sep 2012 at 3:52

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I only getting Admob ads on ios 6, not iAD. So im trying to implement Admob 
Mediation. We will se how that gonna go.

Original comment by shakirov...@gmail.com on 22 Sep 2012 at 6:18

GoogleCodeExporter commented 9 years ago
I tried and same results. If others are getting the same results, then its a 
big fail on Apple's end. New iOS comes up and it cant show their own ad 
networks ads. Sound like a job pretty well done.

Original comment by mikko...@gmail.com on 22 Sep 2012 at 9:46

GoogleCodeExporter commented 9 years ago
I tried my older app, downloaded from appstore on iphone 4s ios 6, i can see 
iAd showing on it. I still think is Adwhirl issue.

Original comment by shakirov...@gmail.com on 23 Sep 2012 at 3:22

GoogleCodeExporter commented 9 years ago
I built test app running just iAd, i tested on iOS 5.1 and it works, and tested 
on iOS 6 not working. 

Original comment by shakirov...@gmail.com on 23 Sep 2012 at 5:37

GoogleCodeExporter commented 9 years ago
I added this

#import <iAd/iAd.h>

 to the top of AdWhirlAdapterIAd.m and then the errors disappeared.

Original comment by ronald.luitwieler on 24 Sep 2012 at 9:33

GoogleCodeExporter commented 9 years ago
Do you see iAd running on iOS 6 ?

Original comment by shakirov...@gmail.com on 26 Sep 2012 at 1:16

GoogleCodeExporter commented 9 years ago
OK, iAd is back with iOS6. Now we also have to build for iphone5 aka armv7S. 
Will AdWhirl work out-of-the-box with arm7s? Or is this the first sign of end 
of AdWhirl? It is still quite pain in the ass to work with admob mediation and 
getting the different banner sizes displayed correctly. Also the admob 
mediation adapters needs to be updated, before fully supporting everything.

I'm no expert etc., but I was just wondering and hoping that AdWhirl structure 
would be such that it does not need any updated libraries etc. for armv7s. 
Naturally the integrated network's libraries would be needed to update, but the 
AdWhirl itself would work just like before.

Original comment by mikko...@gmail.com on 30 Sep 2012 at 11:41

GoogleCodeExporter commented 9 years ago
#import <iAd/iAd.h>   did the trick.  It works for iOS6.

But on my device, with iOS 5, it says "requiredContentSizeIdentifiers must not 
be empty".

Apple documentation only states that requiredContentSizeIdentifiers  is 
deprecated but doesn't mention an option.

Very disappointing.

Original comment by diogo.he...@gmail.com on 5 Oct 2012 at 5:16