search

shaozilee / bmp-js

A pure javascript BMP encoder and decoder for node.js
MIT License
87 stars 46 forks source link

Added type definition file #29

Closed crutchcorn closed 3 years ago

crutchcorn commented 5 years ago

While #34 attempts to rewrite using Typescript, this pull request simply adds Typescript typings to the package, reducing the potential for breaking changes/etc

crutchcorn commented 3 years ago

Turns out that shortly after this PR, a @types package was published.

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/41199

After reviewing those types, they seem super accurate. Closing this PR in favor of @types/bmp-js package