search

shapeblue / Trillian

Trillian - flexible monkey powered CI/CD
Apache License 2.0
14 stars 13 forks source link

Restore tests to execute and fix number of tests executed #138

Closed nvazquez closed 3 years ago

nvazquez commented 3 years ago

The tests under the misc/ directory have been excluded from smoke tests execution for many years, after the latest changes are running and failing: image image

DaanHoogland commented 3 years ago

in 17a08fa0f5b464564a2fc36081b60ee721fceb68 there was

NUMTESTS=`find $TESTDIR/test_*.py | wc -l`
run_start_time="$(date -u +%s)"
counter=1
PASSES=0
# FIXME: make separate list of `dangerous` tests and those that may be run in parallel
FILES=$(ls $TESTDIR/test_*py | grep -v test_host_maintenance | grep -v test_hostha_kvm)

NUMTESTS and FILES where aligned to include the same files. I do not think this fix is appropriate. Now tests under smoke are not run in a smoke test run. I think if we don't want them they must be moved out of the smoke directory.

nvazquez commented 3 years ago

Update: as discussed offline this fix was to revert the smoke test falures after merging PR #135, those tests were never executed before that. @DaanHoogland has created a PR to move the test files to a new directory: https://github.com/apache/cloudstack/pull/5456