shapelets / khiva

An open-source library of algorithms to analyse time series in GPU and CPU.

Mozilla Public License 2.0

228 stars 30 forks source link

The type of the returned array 'distances' by the C binding was of the same type as the input time series. When the input time series was of type integer the distances were being returned truncated.

Make sure you have checked all steps below.

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Benchmarks

[ ] My PR adds the following micro benchmarks OR does not need benchmarks for this extremely good reason:

Commits

[ ] My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

License

[ ] Add a Mozilla Public License 2.0 license header to all the new files.

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

Codecov Report

Merging #116 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files          16       16           
  Lines        1722     1722           
=======================================
  Hits         1682     1682           
  Misses         40       40

Impacted Files	Coverage Δ
src/khiva/matrix.cpp	`98.87% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b4bf98...ef22742. Read the comment docs.