shapelets / khiva

An open-source library of algorithms to analyse time series in GPU and CPU.
https://khiva.readthedocs.io/
Mozilla Public License 2.0
228 stars 30 forks source link

Missing Test for Features::localMaximals() function #68

Closed avilchess closed 5 years ago

avilchess commented 5 years ago

Describe the bug Function features::localMaximals(tss) is not tested, we need to add its test.

Error Message:

libc++abi.dylib: terminating with uncaught exception of type af::exception: ArrayFire Exception (Invalid input size:203): In function dim_t af::calcDim(const af_seq &, const dim_t &) In file src/backend/dim4.cpp:205 Invalid dimension for argument 1 Expected: seq.begin >= -DBL_MIN && seq.begin < parentDim

In function af::array af::array::array_proxy::operator array() In file src/api/cpp/array.cpp:719 Abort trap: 6

avilchess commented 5 years ago

Closing this issue, the function has been fixed and its corresponding test has been added to the set of features tests.