Closed ikarienator closed 7 years ago
Good point... that will be just a map on the table
On Mon, Nov 14, 2016 at 8:22 PM Michael Ficarra notifications@github.com wrote:
@michaelficarra commented on this pull request. In src/main/java/com/shapesecurity/functional/data/HashTable.java https://github.com/shapesecurity/shape-functional-java/pull/28#pullrequestreview-8535629 : @@ -181,6 +185,15 @@ public boolean containsValue(@NotNull V value) { return this.find(p -> p.right == value).isJust(); } @NotNull public ImmutableList keys() { Should return an ImmutableSet, right? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shapesecurity/shape-functional-java/pull/28#pullrequestreview-8535629, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZ2MAErkcjeZHNGJMyGuMKcjPnFFfgrks5q-TORgaJpZM4KyDEl .
In src/main/java/com/shapesecurity/functional/data/HashTable.java https://github.com/shapesecurity/shape-functional-java/pull/28#pullrequestreview-8535629 :
@@ -181,6 +185,15 @@ public boolean containsValue(@NotNull V value) { return this.find(p -> p.right == value).isJust(); } @NotNull public ImmutableList keys() {
@@ -181,6 +185,15 @@ public boolean containsValue(@NotNull V value) { return this.find(p -> p.right == value).isJust(); }
Should return an ImmutableSet, right?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shapesecurity/shape-functional-java/pull/28#pullrequestreview-8535629, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZ2MAErkcjeZHNGJMyGuMKcjPnFFfgrks5q-TORgaJpZM4KyDEl .
Good point... that will be just a map on the table
On Mon, Nov 14, 2016 at 8:22 PM Michael Ficarra notifications@github.com wrote: