search

shapesecurity / shift-parser-js

ECMAScript parser that produces a Shift format AST
http://shift-ast.org/parser.html
Apache License 2.0
249 stars 28 forks source link

Fix #263: update to unicode 8.0.0. Also remove esutils. #342

Closed bakkot closed 7 years ago

bakkot commented 7 years ago

esutils has not published a version with unicode 8.0.0, so replace the parts of it we need with in-house versions of the required methods.

bakkot commented 7 years ago

Are we okay using Set and Array#fill? If we're using Set, would checking set inclusion be faster than the regexp?

We are (node 4, woo!), but it's not faster. I checked.

bakkot commented 7 years ago

@michaelficarra addressed comments.