search

shapesecurity / shift-parser-js

ECMAScript parser that produces a Shift format AST
http://shift-ast.org/parser.html
Apache License 2.0
248 stars 28 forks source link

Lint #368

Closed bakkot closed 6 years ago

bakkot commented 6 years ago

Uses the same eslint config as we use elsewhere, except that I've explicitly added 'no-constant-condition': ['error', { "checkLoops": false }] as an exception so that our while (true) works don't cause lint errors.

Also enforces lint on CI.

michaelficarra commented 6 years ago

You can use for (;;) instead to avoid the no-constant-condition failures. Though arguably you shouldn't be able to.

bakkot commented 6 years ago

while (true) seems cleaner. I don't want my linter asking me to write less clean code.