Open jugglinmike opened 6 years ago
The project's linting rules disallow re-assignment of function parameters, and this patch doesn't satisfy that restriction. However, there are a number of previously-existing infractions, so I'm not sure if the linting rules are still being enforced.
The build is failing because you'll need to add yourself to the contributors file here (sorry for the hassle).
I think this will probably need to wait until the 2019 branch, separately, since this was a normative change which didn't occur until after the 2018 spec was cut. (We track yearly releases, rather than trying to match the current spec at any given time.)
The build is failing because you'll need to add yourself to the contributors file here (sorry for the hassle).
No worries. I'm no stranger to frustrating CLA overhead, myself. Signature offered here: https://github.com/shapesecurity/CLA/pull/28
I think this will probably need to wait until the 2019 branch, separately, since this was a normative change which didn't occur until after the 2018 spec was cut. (We track yearly releases, rather than trying to match the current spec at any given time.)
That's fine by me, as long as I know the patch is otherwise acceptable, I'll leave the merging in your hands.
Commit message:
Would you folks like me to also add tests directly into this project?