Closed Protryon closed 5 years ago
LGTM, but needs tests.
(Also, you'll need to get lint and tests passing; you can run npm run lint
and npm run test
locally.)
Then we can get rid of
TokenType.ESCAPED_KEYWORD
.
That would require adding an additional check (for !token.escaped
) every time we consume any of the many keyword tokens. I don't think it's worth it.
Yeah you're probably right. We at least shouldn't mark ESCAPED_KEYWORD
s with escaped: false
, though.
This should at least have the cases in #376 as tests.
Fixes issue #376.