search

shapeshift / hdwallet

A library for interacting with hardware wallets from JS/TS.
https://hdwallet.shapeshift.now.sh/
MIT License
208 stars 89 forks source link

Integrate MetaMask into HDWallet #336

Closed notatooyou closed 2 years ago

notatooyou commented 3 years ago

ShapeShift DAO HDWallet Bounty

Create support for MetaMask in HDWallet. Only need support for Ethereum and ERC20s. No other supported coins are required for this bounty.

Acceptance Criteria:

1) All the Ethereum and ERC20 functions in examples/sandbox/index.html work correctly when run in a local browser. The sandbox can easily be run locally. 2) Tests created in integration/src/metamask.test.ts

Details:

Add a new folder in the /packages folder. The current packages/hdwallet-portis should be a good starting point for creating /packages/hdwallet-metamask.

Implement all appropriate HDWallet interfaces including adapter, info, and ethereum. The transport interface can be an empty interface. Refer to the Portis transport interface as a reference.

Bounty will be paid once PR is submitted, reviewed and tested by core dev team, and merged. Changes may be required prior to merging.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 3999.9873 FOX (1151.53 USD @ $0.29/FOX) attached to it as part of the shapeshift fund.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 265 years, 1 month from now. Please review their action plans below:

1) selestriel has applied to start work _(Funders only: approve worker | reject worker)_.

so how this works ? going on and play with it , will be stable coin or volatility will be high

Learn more on the Gitcoin Issue Details page.

joshtharakan commented 3 years ago

@notatooyou started working on this one. Will share updates on completion of milestones

gitcoinbot commented 3 years ago

@joshtharakan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

joshtharakan commented 3 years ago

started working on this. but had to stop in between due to some personal emergency, I am continuing

joshtharakan commented 3 years ago

@joshtharakan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] reminder (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Yes I am.

jjfarrow commented 3 years ago

@joshtharakan when do you expect to have a PR ready for review? Would you be wiling to post up a draft PR in progress - we can help be sure you are on the right track. Thanks.

notatooyou commented 3 years ago

@joshtharakan Was logged in with my other github account when I posted that comment. Just want you to know this is me asking for status and a draft PR in progress. Thanks.

gitcoinbot commented 3 years ago

@joshtharakan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

joshtharakan commented 3 years ago

@notatooyou sorry that I was down with covid the entire last week and I couldn't make much progress. I am now able to continue. I will try to make some progress within 1-2 days and if I couldn't, I will abandon this for you to assign someone else. Apologies for the delay and less updates

0xdef1cafe commented 3 years ago

hey @joshtharakan, sorry to hear you were sick with covid! just want to follow this one up again. we're going to need this by the end of this week.

will you be able to deliver this by october 17th?

gitcoinbot commented 3 years ago

@joshtharakan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 3 years ago

@joshtharakan Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

0xdef1cafe commented 3 years ago

hi @joshtharakan - we are going to have to take over this internally due to time constraints.

gitcoinbot commented 3 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 3999.9873 FOX (1316.80 USD @ $0.32/FOX) attached to this issue has been cancelled by the bounty submitter

mrnerdhair commented 2 years ago

Closed by #359.