search

shapeshift / hdwallet

A library for interacting with hardware wallets from JS/TS.
https://hdwallet.shapeshift.now.sh/
MIT License
208 stars 90 forks source link

feat: add hdwallet-metamask-shapeshift-multichain adapter #628

Closed 0xdef1cafe closed 1 year ago

0xdef1cafe commented 1 year ago

Disregard the below, this is now published as alpha: https://www.npmjs.com/package/@shapeshiftoss/metamask-snaps-adapter

Note, we had to bump tsc here to accomodate for the version in metamask-snaps monorepo (which we can't avoid because of new TS features from TS 4.4+ that need to be supported in some snaps transient dependencies), which subsequently broke a lot of things at type-level, explaining the disgusting amount of ts-ignores in this diff.

~~Opening draft to visualize the diff Note, both https://github.com/shapeshift/metamask-snaps/pull/100, https://github.com/shapeshift/hdwallet/pull/628, and https://github.com/shapeshift/web/pull/5166 assume verdaccio running on default port 4873, and all packages published there:~~

image

This is only for development purposes, and config should be reverted to default uplink before merging each of these PRs.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 6:43pm
gomesalexandre commented 1 year ago

Opening because CI is now green, performing second pass self-review

gomesalexandre commented 1 year ago

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.