Closed gomesalexandre closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
hdwallet | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 18, 2023 6:46pm |
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
null
resolutions to hw-app-eth'sethSignTx
, effectively fixing CoW approvals (and other blind signing Txs) broadcasting for Ledger, see Ledger docs https://github.com/LedgerHQ/ledgerjs/blob/master/packages/hw-app-eth/README.md#parameters-2 and web fix https://github.com/shapeshift/web/commit/faef83a30c991a6285292e9c33492d2e5df8786fethSignMessage
for Ledger, by removing the0x
prefix in case we're passing a 0x-prefixed string, since Ledger's internal has aBuffer.from(message, "hex").length
check which will return 0 and end up in things falling later down the line. See https://github.com/LedgerHQ/ledger-live/blob/4b24a9b09be91c40497d82995fe16b67a05adf41/libs/ledgerjs/packages/hw-app-eth/src/Eth.ts#L369