feat: eip-712 structured signing - Githubissues

shapeshift / hdwallet

A library for interacting with hardware wallets from JS/TS.

https://hdwallet.shapeshift.now.sh/

MIT License

208 stars 90 forks source link

feat: eip-712 structured signing #673

Closed gomesalexandre closed 4 months ago

gomesalexandre commented 4 months ago

[x] KK (already implemented and confirmed working)
[x] Native (already implemented)
[x] MM multichain
[x] Coinbase
[x] Ledger
[x] Native (already implemented)
[x] not authored for MM, this adapter is not used anymore, we should probably remove it, and while at it renames its @shapeshiftoss/hdwallet-shapeshift-multichain name to @shapeshiftoss/hdwallet-metamask-shapeshift-multichain if that's possible, seems like an oversight when this package was authoredMM

Testing

Test me with https://github.com/shapeshift/web/pull/7420

Ensure MM and Coinbase Wallet now display typed data when signing CoW orders signing
Ensure native is still happy when signing CoW orders
Ensure KK is still happy with CoW, and now displays slightly more data than before (i.e hash domain and order, vs. only a hashed message signing on develop)
Ensure Ledger is happy with CoW, and now displays slightly more data than before (i.e domain version and chainId vs. only a hashed message signing on device on develop)

Screenshots

Native

https://explorer.cow.fi/arb1/orders/0x11bd0702c9119f88985a468a2fea636e87f3963f185f60701d06c3ddbfd9f17f5daf465a9ccf64deb146eeae9e7bd40d6761c98666a24041?tab=overview

MetaMask

https://explorer.cow.fi/arb1/orders/0xe5480460293ab537525267377dc397157c1a0a24033c2007b19f350f3fc0ce0d5daf465a9ccf64deb146eeae9e7bd40d6761c98666a2411a?tab=overview

Ledger

https://explorer.cow.fi/orders/0x8fd2cdb01900ec4392d269224b7f0891e8cae4a6dd1ca8c1fccf82e0a92615805daf465a9ccf64deb146eeae9e7bd40d6761c98666a2419f?tab=overview

KeepKey

https://explorer.cow.fi/orders/0x56c858725816f2511aafd07ded2dc890efa9d250e37eb3038b79d7b6c4aa54d85daf465a9ccf64deb146eeae9e7bd40d6761c98666a2422b?tab=overview

Coinbase

https://explorer.cow.fi/arb1/orders/0x6997005bc0b185b06e8617af6acadf16d581f7e46c4561f797ec8c934f53591a5daf465a9ccf64deb146eeae9e7bd40d6761c98666a2429c?tab=overview

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hdwallet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 2, 2024 4:59pm