shapeshift / hdwallet

A library for interacting with hardware wallets from JS/TS.
https://hdwallet.shapeshift.now.sh/
MIT License
208 stars 90 forks source link

feat: real EIP-712 structured signing for Ledger #674

Closed gomesalexandre closed 2 months ago

gomesalexandre commented 4 months ago

Description

This PR is a stretch of https://github.com/shapeshift/hdwallet/pull/673, authored as a separate PR, since it is inherently more risky:

Risks

Theoretically low, but given how Ledger types seem to break across releases, it's better to assume runtime is the same and full of breaking changes. Do a full regression testing of Ledger:

Testing

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 7:33pm
gomesalexandre commented 2 months ago

Latest e2e testing, including EVM (structured signing), UTXO, ATOM and RUNE Txs:

https://jam.dev/c/5bc01935-1d3e-49d1-b22f-7ba3929352d0