search

shapeshift / hdwallet

A library for interacting with hardware wallets from JS/TS.
https://hdwallet.shapeshift.now.sh/
MIT License
208 stars 90 forks source link

feat: only connect solana on pairDevice() #691

Closed gomesalexandre closed 4 weeks ago

gomesalexandre commented 1 month ago

Description

Does what it says on the box, making connection some better for Solana accounts without an EVM address present.

The reason why EVM addy was used as a deviceId (and in pairDevice()) was because Solana support wasn't implemnented then, meaning we assumed EVM support in Phantom. However, this is not always guaranteed to be true e.g with automagically discovered accounts that may not contain EVM accounts, and/or manually added accounts which may also not.

Fixed by not pairing EVM accounts on instantiation, which makes things some better, though the error is always present until we bring the same notion of runtime chains to Phantom as we do for Solana (which we probably should)

Issue

Tackles https://github.com/shapeshift/web/issues/7973

Screenshots

https://jam.dev/c/be486369-d71c-44f0-831e-396caeac5c52

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 0:44am