search

shapeshift / lib

MIT License
22 stars 54 forks source link

Remove patch from lib #139

Open 0xdef1cafe opened 2 years ago

0xdef1cafe commented 2 years ago

https://github.com/shapeshift/lib/pull/136/files#diff-c3f51ca8777f4cc6e6128ef417f7c38d87662e7413cd8471dfc9237b5685beb4R1-R17

this is not production ready and isn't the solution. we need to fork this repo and fix it.

0xean commented 2 years ago

@reidrankin - Can you please create a ticket in HD wallet to remove all bithighlander dependencies?

mrnerdhair commented 2 years ago

Huh, I thought this was taken care of already. Looks like tendermint-tx-builder still has a transitive dep on an old version of his bitcoinjs fork, though. We'll need to fork that and update it.

0xean commented 2 years ago

assigned to @BitHighlander

0xdef1cafe commented 2 years ago

this will be addressed by the new https://github.com/shapeshift/tendermint-tx-builder repo

mrnerdhair commented 2 years ago

Blocked by shapeshift/hdwallet#409.

0xean commented 2 years ago

@mrnerdhair - can you comment on if this ticket is still valid?