feat: unit improvements - Githubissues

shapeshift / rFOX

rFOX - RUNE rewards for FOX stakers

MIT License

0 stars 0 forks source link

feat: unit improvements #13

Closed gomesalexandre closed 2 months ago

gomesalexandre commented 2 months ago

Description

This PR:

adds full coverage including all branches
runs CI on PRs and pushes targeted to develop/main
uses OZ safeTransfer / safeTransferFrom for transfers

As the current last PR of the stack, also adds some improvements to the contract as noted by @0xean in https://github.com/shapeshift/rFOX/pull/2, namely:

Not sure on this one, but do we want to also emit the oldRuneAddress if we are changing it. (https://github.com/shapeshift/rFOX/pull/2#discussion_r1558067541)

can we do better than this? I would imagine rune addresses are specific length / number of bytes so we might be able to (https://github.com/shapeshift/rFOX/pull/2#discussion_r1558070906)

Issue

closes https://github.com/shapeshift/rFOX/issues/5

Screenshots