search

shapeshift / security

Issue and discussion tracking for the Security Workstream.
1 stars 0 forks source link

review(RegenFarms): review FOX/HNY rewards contract deployment #35

Closed mrnerdhair closed 2 years ago

mrnerdhair commented 2 years ago

Ref: https://discord.com/channels/@me/948593968197812255/958404075223932951

mrnerdhair commented 2 years ago

Did PR Review: https://github.com/Giveth/giv-token-contracts/pull/55

Left a review on this PR. Was able to verify some params, and have a few notes to double-check others. (In particular, initTime could be a mistake?) I also note that while 0x34d27210cC319EC5281bDc4DC2ad8FbcF4EAEAEB owns 0x502EC7a040F486EE6Cb7d634D94764874B29dE68, 0x5f672d71399d8cDbA64f596394b4f4381247E025 owns its proxy admin contract at 0x911EdAff1642db03c72A76De1026C54c85785744. willyfox, note that if the DAO needs ownership of the contract it'll need to have the proxy admin too.