search

shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
159 stars 180 forks source link

No tx found using link in BTC transaction toast #1183

Closed Lychbot closed 2 years ago

Lychbot commented 2 years ago

Overview

After completing a successful send of a BTC transaction, a green transaction toast window will appear in the top right of your screen. Clicking the link immediately after the BTC send in the transaction toast will take you to an invalid explorer page because the TXID is not found yet.

Discord link: https://discord.com/channels/554694662431178782/873244924026449940/953394763602731081

Reference

Screen_Shot_2022-03-15_at_6 17 59_PM

Acceptance Criteria

Delay send toast notification for 5 seconds.

Need By Date

No response

Screenshots/Mockups

No response

Ownership

1 hour

Stakeholder

@0xdef1cafe

Bounty Hunters

DiggyDiggy2 commented 2 years ago

Delay the toast until there is a TXID, because it's not considered successful until we have one.

gomesalexandre commented 2 years ago

This might be useful for it: https://github.com/shapeshift/web/pull/1179

0xean commented 2 years ago

race condition w/ blockcypher picking up the transaction.

purelycrickets commented 2 years ago

This does not have an estimate of hours of work.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 250.0 FOX (84.85 USD @ $0.34/FOX) attached to it as part of the shapeshift fund.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 264 years, 6 months from now. Please review their action plans below:

1) rokko has applied to start work _(Funders only: approve worker | reject worker)_.

Yes , i can do it .

I propose creating a simple sleep function e.g. const sleep = (ms: number) => new Promise(resolve => setTimeout(resolve, ms))

I think it is best to use await sleep(timeout) rather than just wrapping it with setTimeout to keep the code clear. 3) dhruv-coder has applied to start work _(Funders only: approve worker | reject worker)_.

I can wrap the toast with an setTimeout() function to delay it for 5 seconds. It seems to be pretty basic task and i am willing to do it.

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 250.0 FOX (81.63 USD @ $0.33/FOX) has been submitted by:

  1. @saujanyanagpal104

@shapeshiftdaobounties please take a look at the submitted work:

saujanyanagpal104 commented 2 years ago

@gomesalexandre @0xdef1cafe Can I know when I get paid for this bounty I picked this from gitcoin and this was my first so I don't know about the process, just asking?

gomesalexandre commented 2 years ago

@gomesalexandre @0xdef1cafe Can I know when I get paid for this bounty I picked this from gitcoin and this was my first so I don't know about the process, just asking?

Hi @saujanyanagpal104 ! Congrats on getting this merged 🎉. We are currently transitioning over on the systems we use for bounties and during that transition period, we need to manually make the payment Txs, we can't do automatic Gitcoin payment on Mainnet. Tyler | ShapeShift will create a thread in #🥳・bounties➕jobs on Discord so you can send an address (it can be the same as you have there) for the bounty to be paid out.

Can you confirm your discord handle? 🙏🏽

saujanyanagpal104 commented 2 years ago

@gomesalexandre Thanks! my discord handle is "converse_spear".

Lychbot commented 2 years ago

fixed and paid. Closing out this ticket

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 250.0 FOX (43.89 USD @ $0.18/FOX) attached to this issue has been cancelled by the bounty submitter