Staked amounts aren’t shown in the total ATOM owned in balance

Lychbot commented 2 years ago

Overview

When ATOMs are staked, total ATOM balance shown on the main dashboard page or the asset detail page doesn't include the staked amount

References and additional details

Recreation steps:

Connect any wallet to app.shapeshift.com or https://4cd99f45.web-29e.pages.dev/
Turn ON CosmosInvestor flag
Go to the Cosmos Asset page
Stake some ATOMs
Notice that the ATOM balance does not include the staked atoms even after the page is refreshed

Acceptance Criteria

Staked amount should be included in the Total ATOM balance, unless this is intended

Need By Date

No response

Screenshots/Mockups

No response

Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

gomesalexandre commented 2 years ago

@elmutt We should be able to use the same calculation as in the balance charts here

elmutt commented 2 years ago

We intentionally left that out of the charts PR because we weren't sure where it should go or what it should look like.

The acceptance criteria on that issue is weird:

"Acceptance Criteria Staked amount should be included in the Total ATOM balance, unless this is intended"

I have no idea if "this is intended". Depending how you look at it it could make sense how it is now or by combining balance with delegations in some parts of the app (dashboard? asset pages?).

It feels like we need product to tell us whats intended here and if additional designs are needed

0xean commented 2 years ago

@DiggyDiggy2 to look into this, and clarify expected behavior.

DiggyDiggy2 commented 2 years ago

We should show the total combined balance (staked plus available) for the balance page and charts
Can we please add this little tag under the users Total Balance on the asset details screen
copy for the tooltip: "You cannot send or trade the amount staked"

DiggyDiggy2 commented 2 years ago

@elmutt - let me know if you need more info

0xean commented 2 years ago

Per discord @elmutt is indeed working on this one

shapeshift / web