shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
157 stars 180 forks source link

Add new underlying asset row to launch FOXy modal #1442

Closed sababa-2019 closed 1 year ago

sababa-2019 commented 2 years ago

Overview

Gm!

When looking at FOXy asset details, there is no reference to it being a staked token, for easy access to the deposit and withdraw modal.

A solution for this was mocked up for Yearn, and can be seen below as the Underlying Asset box. This same functionality is desired for the FOXy asset page.

Screen_Shot_2022-04-07_at_5 12 13_PM

Underlying asset would be 'FOX' and upon click would bring the user to the FOX asset page (https://app.shapeshift.com/assets/eip155:1/erc20:0xc770eefad204b5180df6a14ee197d99d808ee52d) where they can manage their position.

References and additional details

Please ping @decentralized-j if further information is needed. Ty!

Acceptance Criteria

  1. FOXy asset page now shows an 'underlying asset' module
  2. Percentage return and number of FOX staked in FOX and USD shown
  3. Upon click, user is taken to FOX asset page

Need By Date

No response

Screenshots/Mockups

No response

Ownership

Estimated effort

3 hours.

Sponsor / Stakeholder

GitHub: 0xApotheosis Discord: 0xApotheosis#2503

Bounty Hunters

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 660.0 FOX (243.18 USD @ $0.37/FOX) attached to it as part of the shapeshift fund.

rast000 commented 2 years ago

Hi @decentralized-j, maybe I misunderstood something, but I already see a box which references to staking on FOX asset page image

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 264 years, 7 months from now. Please review their action plans below:

1) lolboysg has been approved to start work.

Hey, I would like to get this job done as I am already familiar with he codebase and it should be done within a day

Learn more on the Gitcoin Issue Details page.

0xApotheosis commented 2 years ago

Hi @decentralized-j, maybe I misunderstood something, but I already see a box which references to staking on FOX asset page

I believe this relates to the FOXy asset page, rather than FOX. FOXy's "underlying asset" is FOX, which we want to show on the FOXy page.

sababa-2019 commented 2 years ago

Hi @decentralized-j, maybe I misunderstood something, but I already see a box which references to staking on FOX asset page

I believe this relates to the FOXy asset page, rather than FOX. FOXy's "underlying asset" is FOX, which we want to show on the FOXy page.

Exactly correct! Thank you for clarifying ser.

Lychbot commented 2 years ago

@lolboysg could see that you have been approved to work. wanted to check, are you still working on this?

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 660.0 FOX (115.87 USD @ $0.18/FOX) attached to this issue has been cancelled by the bounty submitter

0xean commented 2 years ago

@lolboysg - can you please provide an update today or we will have to move to another contributor.

0xtekgrinder commented 2 years ago

I am awaiting for @decentralized-j answer to know if I should continue on this bounty as I don't know yet if I should implement a generic form of the staked asset modal or just hardcode one for foxy

0xean commented 2 years ago

generic form please!

Lychbot commented 2 years ago

removing this as a bounty for now basing on this convo in discord (https://discord.com/channels/554694662431178782/886041582422356018/968164015882764338)

0xdef1cafe commented 1 year ago

@shapeshift/operations this could be given to a trusted community contributor

0xApotheosis commented 1 year ago

@0xdef1cafe on Discord you said: "Any work here will be rather futile at the moment given @Major Hayes working on single sided staking abstraction" (https://discord.com/channels/554694662431178782/886041582422356018/968164015882764338)

Has anything changed since that comment was made?

chxash commented 1 year ago

@decentralized-j This is the current state of the "underlying assets" box :

underlying

This is pretty different from the expectation of this issue, is it expected to change this box for every underlying asset or should we do a specific display for FOXy / FOX ?

major commented 1 year ago

@0xdef1cafe on Discord you said: "Any work here will be rather futile at the moment given @major Hayes working on single sided staking abstraction" (https://discord.com/channels/554694662431178782/886041582422356018/968164015882764338)

Has anything changed since that comment was made?

👋🏻