search

shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
169 stars 179 forks source link

Gracefully display assets without available market data #1555

Closed purelycrickets closed 2 years ago

purelycrickets commented 2 years ago

Overview

Continuation of https://github.com/shapeshift/web/issues/921

References and additional details

see https://github.com/shapeshift/web/issues/921

Acceptance Criteria

see: https://github.com/shapeshift/web/issues/921

Need By Date

No response

Screenshots/Mockups

No response

Ownership

Estimated effort

4 hours

Sponsor / Stakeholder

0xean

Bounty Hunters

purelycrickets commented 2 years ago

https://github.com/shapeshift/web/issues/921

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 899.9882 FOX (305.44 USD @ $0.34/FOX) attached to it as part of the shapeshift fund.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 264 years, 6 months from now. Please review their action plans below:

1) yukidotn has applied to start work _(Funders only: approve worker | reject worker)_.

I have some experience in frontend development, please give me a chance! 2) muhammetaliakbay has applied to start work _(Funders only: approve worker | reject worker)_.

Estimated work time: 2 hours for understanding the app for the first time and 2 to 8 hours for applying the fix and 2 hours for testing the changes. Totally 6 to 12 hours.

Estimated days: I can work on it for 3 hours per day, which makes 2 to 4 days in total. 3) piyushpi07 has applied to start work _(Funders only: approve worker | reject worker)_.

Hi, I have 3+ years of experience in full-stack development. Estimated work hours are 3-5 hours once functional requirements are made clear by the team. 4) saujanyanagpal104 has applied to start work _(Funders only: approve worker | reject worker)_.

I will just create a simple empty state component for the assets which are not loading and it will have some text or some UI to communicate to the user that this asset is not available right now. 5) hpratt has been approved to start work.

Hello, I have experience with React and Redux, think I can address this. Glanced through the code and I think I understand where this should be implemented.

state layer: add fields and selectors to MarketDataState to track when requests for market data or price history have failed or completed but returned empty

API layer: dispatch events to reflect missing/errored results in the catch blocks of findByCaip19 and findPriceHistoryByCaip19

view layer: (1) check for missing/errored price history in PriceChart and BalanceChart components (2) check for missing/errored market data in Asset and AssetChart components

can open a PR in 2-3 days if this seems like it will address the issue, let me know 6) tranluan1 has applied to start work _(Funders only: approve worker | reject worker)_.

Tôi có khả năng làm việc về các lĩnh vực phát triển các dự án Kế hoạch này tôi sẽ làm được để đưa nó lên đà phát triển mạnh 7) nwakaku has applied to start work _(Funders only: approve worker | reject worker)_.

Having read through the project description I'm sure I can do exactly what you want within a specific time frame

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 899.9882 FOX (261.94 USD @ $0.29/FOX) has been submitted by:

  1. @hpratt

@shapeshiftdaobounties please take a look at the submitted work:

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 899.9882 FOX (158.0 USD @ $0.18/FOX) attached to this issue has been cancelled by the bounty submitter