Closed gomesalexandre closed 1 year ago
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Description
Does what it says on the box - removes the hardcoded
accountNumber
in favor of thebip44Params.accountNumber
from the relevant account metadata field.Notice
Pull Request Type
Issue (if applicable)
Risk
accountNumber
, however, this has only been tested with MM, and a cross-wallet FOX-ETH/LP regression test should be done to ensure we are consistently getting andaccountNumber
, and the FOX-ETH LP/Farming features still work.Testing
Engineering
accountNumber
memoized value to ensure it is null while the metadata is loading / the correct account number after it's been derivedOperations
MultiAccount
flag on and off (this assumesFoxLP
andFoxFarming
flags on for the two features, respectively)Screenshots (if applicable)