Closed gomesalexandre closed 1 year ago
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Current dependencies on/for this PR:
This comment was auto-generated by Graphite.
Description
This adds multi account support for Yearn DeFi opportunities:
Notice
Pull Request Type
Issue (if applicable)
closes https://github.com/shapeshift/web/issues/2605
Risk
Yearn modal should be fully regression tested - in theory, this brings no changes for now and uses programmatic accountNumber vs. hardcoded accountNumber, but this requires a breaking(ish) change in the lib PR.
Testing
MultiAccounts
flag on, the account dropdown should be present in Yearn opportunities Overview, Deposit, and Withdraw stepsMultiAccounts
flag off, there should be no user-facing changes nor regressions with the current flowEngineering
console.log
or debugaccountNumber
props in components to ensure the right account number is passed downOperations
Screenshots (if applicable)