search

shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
157 stars 180 forks source link

(ALPHA) V2: Remove second "Pair" wallet modal #490

Closed SS-FOX-McCloud closed 2 years ago

SS-FOX-McCloud commented 2 years ago

Acceptance Criteria

When a user selects the wallet they want to pair to V2 the wallet should connect without needing a click on the next modal. We still need some spinner / loading feedback to the user after the click to pair to ensure they know something is happening.

1) remove second modal and click 2) use spinner on primary modal to show loading is occurring after the initial click on wallet type while the dashboard loads.

Screen Shot 2021-11-22 at 12 55 06 PM Screen Shot 2021-11-22 at 12 55 14 PM
0xean commented 2 years ago

@elmutt / @SS-FOX-McCloud - Okay with me selecting this as an issue to bounty? should be a really easy hello world task for a new contributor.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 250.0 FOX (171.47 USD @ $0.69/FOX) attached to it as part of the ShapeShift fund.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 264 years, 11 months from now. Please review their action plans below:

1) boyin0x has applied to start work _(Funders only: approve worker | reject worker)_.

Hi 0xean, I'd like to work on this bounty. Thanks.

Learn more on the Gitcoin Issue Details page.

elmutt commented 2 years ago

@elmutt / @SS-FOX-McCloud - Okay with me selecting this as an issue to bounty? should be a really easy hello world task for a new contributor.

It could definitely be a good bounty.

It is more complicated than it initially appears because of the way the whole wallet connect modal system is setup. Someone familiar with that area of the code should probably review the PR to ensure things are moving in the right direction

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 264 years, 11 months from now. Please review their action plans below:

1) armr-dev has applied to start work _(Funders only: approve worker | reject worker)_.

  1. Update SUPPORTED_WALLETS to contain how to connect to each wallet;
  2. Update WalletProvider state to support directly connecting to the wallet instead of setting the INITIAL_ROUTE with the functions defined in the first step;
  3. Remove redirections to the "Pair" modal;
  4. Update tests.

Learn more on the Gitcoin Issue Details page.

armr-dev commented 2 years ago

There seems to be an open PR for this issue already (#537). I'll wait for the code review of it to start working.

0xean commented 2 years ago

@armr-dev - feel free to start work, the other PR has been closed.

0xean commented 2 years ago

Issue has been updated to make the AC more clear as well! Thanks @armr-dev

armr-dev commented 2 years ago

Thank you, @0xean! I'll start working on this one as soon as I finish the other one!

0xean commented 2 years ago

@armr-dev - just wanted to check in and see how things are progressing? Do you need some help or are you making progress?

armr-dev commented 2 years ago

@armr-dev - just wanted to check in and see how things are progressing? Do you need some help or are you making progress?

Hey @0xean! I'm so sorry I haven't been able to work on this yet. I got really really sick this week (and still am) and wasn't able to work on anything yet. I'm recovering and hopping to be able to work on this on this weekend, probably by Sunday.

Again, I'm sorry for the delay. I'll let you know when I've made some progress.

0xean commented 2 years ago

@armr-dev - no problem, get well and we can pick back up once you are recovered. Thank you for letting us know.

0xean commented 2 years ago

@armr-dev - Hope you are feeling better. Can you please comment on when you believe you will have a PR ready for us to review on this one?

armr-dev commented 2 years ago

@armr-dev - Hope you are feeling better. Can you please comment on when you believe you will have a PR ready for us to review on this one?

Hey @0xean! Again, I'm so sorry for the delay. I'm getting better still, but I'm feeling much better than before, so that's good. The past couple of weeks have been crazy and I haven't been able to work on this issue.

The good news is that I'll be able to work on this one on this weekend, so here's hoping that by Monday or Tuesday the PR will be ready for you guys to review.

cjthompson commented 2 years ago

@SS-FOX-McCloud - what's the UX for an error state if MetaMask doesn't pair for whatever reason?

0xean commented 2 years ago

Closing this issue and paying out bounty as we need a different solution for displaying error states.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 250.0 FOX (145.83 USD @ $0.58/FOX) has been submitted by:

  1. @armr-dev

@0xean please take a look at the submitted work:

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 250.0 FOX (110.96 USD @ $0.44/FOX) attached to this issue has been cancelled by the bounty submitter