shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
157 stars 180 forks source link

Complete WarningAcknowledgement implementation #6707

Open 0xApotheosis opened 2 months ago

0xApotheosis commented 2 months ago

Overview

A follow-up to https://github.com/shapeshift/web/pull/6647, we need to add the new WarningAcknowledgement component to the following user flows:

References and additional details

Use the existing implementation as a guide. We'll want to replace the cases noted in https://github.com/shapeshift/web/issues/6605 and https://www.figma.com/file/ZK7L1l38Kzc4SlKekbPnm0/Modals?type=design&node-id=1-250&mode=design&t=MJPI055hYriNnDxz-0 with the new component for a more consistent user experience.

Acceptance Criteria

The WarningAcknowledgement component is in place for each of the cases above.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

0xApotheosis commented 2 months ago

Adding to groomed, as it's a completion of the existing groomed task.

0xApotheosis commented 2 months ago

Note to self: grep .dangerousWithdrawWarning and remove those cases.

gomesalexandre commented 3 weeks ago

@0xApotheosis is 1. being checked correct? As far as I can tell, savers is still using the previous dangerous withdraw div.

With that being said, I wasn't able to recreate the dangerous withdraw logic, as minimum amounts seem to gracefully catch it, though I don't have a BTC saver deposit, which could be the affected one.

gomesalexandre commented 3 weeks ago

Note to self: grep .dangerousWithdrawWarning and remove those cases.

@0xApotheosis finally managed to repro withdraws on BTC despite current fees endpoint shenanigans and it looks like indeed, we can remove these, since the minimum effectively catches dangerous withdraws, meaning we don't need neither the current dangerousWithdrawWarning nor the new ack?

Image

Image

Image

0xApotheosis commented 2 weeks ago

You are absolutely right @gomesalexandre! I've removed that line item from the ticked, as I think it was actually meant to reference LPs.