search

shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
159 stars 180 forks source link

upgrade react-router-dom #675

Closed 0xdef1cafe closed 2 years ago

0xdef1cafe commented 2 years ago

Overview

We currently use react-router-dom on version 5.2.0 and want to update to the latest major version, as of writing, 6.2.1.

There is an example closed PR here showing what is required.

This will mainly involve fixing type errors and breaking changes throughout the app and will take some time to get all of the errors fixed after the upgrade.

Acceptance Criteria

Bounty Hunters

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 1700.0 FOX (842.21 USD @ $0.5/FOX) attached to it as part of the ShapeShift fund.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 264 years, 10 months from now. Please review their action plans below:

1) zerquix18 has applied to start work _(Funders only: approve worker | reject worker)_.

Hello. I have gone through this process before using the upgrade guide: https://reactrouter.com/docs/en/v6/upgrading/v5

I checked the code and it seems you're already using hooks for everything, which makes the process smoother. I can take this one. 2) developerfred has been approved to start work.

I have experience with react, you can check my github and I will update and fix any errors.

Learn more on the Gitcoin Issue Details page.

developerfred commented 2 years ago

@0xean my expectation for this bounty is 2 hours to finalize it

0xean commented 2 years ago

Awesome, that is great. We thought it would take longer, but all that matters is that it works in the end. thanks for applying!

developerfred commented 2 years ago

Awesome, that is great. We thought it would take longer, but all that matters is that it works in the end. thanks for applying!

you're right it's taking a little longer lol

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 1700.0 FOX (842.21 USD @ $0.5/FOX) has been submitted by:

  1. @developerfred

@0xean please take a look at the submitted work:

amitojsingh366 commented 2 years ago

are you guys still looking for this being done? curious since the previous pr was closed. If yes i'd like to take this up

0xean commented 2 years ago

Yes, @developerfred is working on it. PR that was closed was mine. It was an attempt to resolve the conflicts present which it did, but wouldn't compile.... But @developerfred is gonna get it finished off in the coming week or so.

developerfred commented 2 years ago

🚀

0xean commented 2 years ago

Disregard, saw the PR is still pending.

developerfred commented 2 years ago

Disregard, saw the PR is still pending.

new version on PR

0xdef1cafe commented 2 years ago

our mistake with creating this bounty

there's no practical benefit of a major version bump from 5 -> 6, as there are issues with memory and nested routers

@0xean this bounty needs paying out due to the work done but we closed the PR and don't need this upgrade done.

gitcoinbot commented 2 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 1700.0 FOX (609.29 USD @ $0.36/FOX) attached to this issue has been approved & issued to @developerfred.