shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
157 stars 180 forks source link

feat: more account management wiring #6780

Closed woodenfurniture closed 2 weeks ago

woodenfurniture commented 2 weeks ago

Description

Incremental progress on wiring up account management. This PR implements:

Fixes:

Excludes:

Pull Request Type

Issue (if applicable)

Progresses #6722

Risk

High Risk PRs Require 2 approvals

High risk as it alters and adds selectors to the portfolio slice.

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

NOTE: When comparing balances between tabs, keep in mind that balances displayed in USD$ fluctuate with market prices so will like not match exactly. Best option is to compare crypto amounts.

With account management feature flag toggled off

With account management feature flag toggled on

Before disabling/enabling accounts via "manage accounts"

After disabling/enabling accounts via "manage accounts"

Engineering

A migration has been added to initialize the new disabledAccountIds for the portfolio slice.

Operations

Screenshots (if applicable)

Walkthru including a trade into a new account:

https://github.com/shapeshift/web/assets/125113430/fcaadd28-4374-45f0-8619-8e4b477a5d9b