[x] :nail_care: New Feature (Breaking/Non-breaking Change)
Issue (if applicable)
Progresses #6722
Risk
High Risk PRs Require 2 approvals
High risk as it alters and adds selectors to the portfolio slice.
What protocols, transaction types or contract interactions might be affected by this PR?
Testing
NOTE: When comparing balances between tabs, keep in mind that balances displayed in USD$ fluctuate with market prices so will like not match exactly. Best option is to compare crypto amounts.
With account management feature flag toggled off
Initial load of portfolio from previous non-empty state works for various wallets (balances, assets etc correct for the account number)
Initial load of portfolio from previous empty state works for various wallets (balances, assets etc correct for the account number)
Trades to/from different accounts (0, 1, 2 etc) working as expected
With account management feature flag toggled on
Before disabling/enabling accounts via "manage accounts"
Initial load of portfolio from previous non-empty state works for various wallets (balances, assets etc correct for the account number)
Initial load of portfolio from previous empty state works for various wallets (balances, assets etc correct for the account number)
Trades to/from different accounts (0, 1, 2 etc) working as expected
After disabling/enabling accounts via "manage accounts"
Initial load of portfolio from previous non-empty state works for various wallets (balances, assets etc correct for the account number)
Initial load of portfolio from previous empty state works for various wallets (balances, assets etc correct for the account number)
Trades to/from different accounts (0, 1, 2 etc) working as expected
Engineering
A migration has been added to initialize the new disabledAccountIds for the portfolio slice.
Description
Incremental progress on wiring up account management. This PR implements:
Fixes:
wallet.deviceId()
promise as a key in react query -> uses string from context insteadExcludes:
Pull Request Type
Issue (if applicable)
Progresses #6722
Risk
High risk as it alters and adds selectors to the portfolio slice.
Testing
NOTE: When comparing balances between tabs, keep in mind that balances displayed in USD$ fluctuate with market prices so will like not match exactly. Best option is to compare crypto amounts.
With account management feature flag toggled off
With account management feature flag toggled on
Before disabling/enabling accounts via "manage accounts"
After disabling/enabling accounts via "manage accounts"
Engineering
A migration has been added to initialize the new
disabledAccountIds
for the portfolio slice.Operations
Screenshots (if applicable)
Walkthru including a trade into a new account:
https://github.com/shapeshift/web/assets/125113430/fcaadd28-4374-45f0-8619-8e4b477a5d9b