Closed 0xApotheosis closed 2 weeks ago
gm @gomesalexandre, ty for the excellent review.
I've unified the EVM connections/UI to use the Ethereum app in https://github.com/shapeshift/web/pull/6790/commits/265120d4a467506fb2c45062770e6edb78d67e01
We still have the THORChain connection issue, which I suspect is caused by await this.transport.call(null, "getAppAndVersion")
returning THORChain
, whereas the slip key is written as Thorchain
in HDWallet's slip44Table
(I suspect incorrectly, as SLIP-0044
lists it as THORChain
too).
This might require another HDWallet update to fix, which I'll look into tomorrow in a separate PR 🙏
Description
LedgerOpenApp
component to match the mocks in https://www.figma.com/file/VEKmwSuhnZVghkUl0VSvN2/Ledger-UX?type=design&node-id=789-420&mode=design&t=aQ5JKr0gg5tyPjyv-0Pull Request Type
Issue (if applicable)
Closes https://github.com/shapeshift/web/issues/6720
Risk
Low - only style changes
None
Testing
Ensure
REACT_APP_FEATURE_ACCOUNT_MANAGEMENT
andREACT_APP_FEATURE_ACCOUNT_MANAGEMENT_LEDGER
feature flags are enabled.Engineering
☝️
Operations
☝️
Screenshots (if applicable)