When a user has insufficient balance for gas, we still fetch estimate regardless, and even worse, we poll for it, meaning the LP deposit will be in a red error loading state for many, many seconds before being actionable... and reverting back to red error loading state.
Though this may be happening in other places as well.
When a user has insufficient funds for gas (which means the gas estimation is guaranteed to fail), we should bail off gas estimations, and other requests we can potentially avoid.
References and additional details
N/A
Acceptance Criteria
Scrutinize balance checks across the app and where estimate calls are made
Write a report of said places in this issue, along with other calls that can be ommitted (if any) when the balance for gas is insufficient
Ensure said calls aren't made anymore when user has insufficient funds
Overview
Spotted on THORChain LP as part of final THOR consolidation testing:
When a user has insufficient balance for gas, we still fetch
estimateregardless, and even worse, we poll for it, meaning the LP deposit will be in a red error loading state for many, many seconds before being actionable... and reverting back to red error loading state.Though this may be happening in other places as well.
When a user has insufficient funds for gas (which means the gas estimation is guaranteed to fail), we should bail off gas estimations, and other requests we can potentially avoid.
References and additional details
N/A
Acceptance Criteria
estimatecalls are madeNeed By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response