Fixes "Wrong account count in account management modal on UTXO chains" #6788 by displaying various UTXO account types, making it clear the account count is in fact correct.
Displays all UXTO accounts (segwit native, segwit, legacy) #6789
Loads native asset balances for all accounts so new ones are not zero if they have funds #6797
Pull Request Type
[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)
Issue (if applicable)
closes #6789
closes #6788
closes #6797
Risk
High Risk PRs Require 2 approvals
Low risk.
What protocols, transaction types or contract interactions might be affected by this PR?
None of the above.
Testing
Check the account count on the manage accounts modal matches the number of accounts in the import accounts drawer. Note that it's very tricky to tell the difference between in inactive account and an active one if there is zero native asset balance on that account (see below for more info).
Check that all UXTO account types segwit native, segwit, legacy appear for a given account number
Check that native asset balances are loaded for accounts that are not auto-added (i.e there is an empty account in between 2 non-empty accounts - you can replicate this by adding 2 new accounts and transferring some coins into the second one - @MBMaria this is already set up on your native wallet for Ethereum). See below for more info.
Engineering
Operations
Screenshots (if applicable)
An ETH account may have some FOX but 0 ETH, so is active:
Similarly, a BTC account may have 0 BTC balance but non-zero thorchain savers balance:
Showing auto-detected accounts up to first empty one (it has 0ETH but has fox, so was detected. the second empty account is actually totally empty). The account after the 2 0ETH accounts has some eth, and the balance is loaded when viewed:
Description
Pull Request Type
Issue (if applicable)
closes #6789 closes #6788 closes #6797
Risk
Low risk.
None of the above.
Testing
Check the account count on the manage accounts modal matches the number of accounts in the import accounts drawer. Note that it's very tricky to tell the difference between in inactive account and an active one if there is zero native asset balance on that account (see below for more info).
Check that all UXTO account types
segwit native,segwit,legacyappear for a given account numberCheck that native asset balances are loaded for accounts that are not auto-added (i.e there is an empty account in between 2 non-empty accounts - you can replicate this by adding 2 new accounts and transferring some coins into the second one - @MBMaria this is already set up on your native wallet for Ethereum). See below for more info.
Engineering
Operations
Screenshots (if applicable)
An ETH account may have some FOX but 0 ETH, so is active:
Similarly, a BTC account may have 0 BTC balance but non-zero thorchain savers balance:
Showing auto-detected accounts up to first empty one (it has 0ETH but has fox, so was detected. the second empty account is actually totally empty). The account after the 2 0ETH accounts has some eth, and the balance is loaded when viewed:
https://github.com/shapeshift/web/assets/125113430/eab0a622-4afe-437f-8547-b2a50a933523