feat: more paranoia re pair asset address only on sym deposits - more paranoia, same reason as above - ensure if we were to ever get into cached calls returning a from (pair) address when it shouldn't, and the above somehow didn't help, we would catch it
two paranoia commits aren't enough? stay ensured this got you covered: https://github.com/shapeshift/web/pull/6800/commits/ab7da60038c9ec8ee3dd2cf6fb8da5e579d179f6, the actual fix the two paranoia commits above act as a bandaid for. The reason was we were consuming the query at <AddLiquidityInput /> time (for legit from address reasons) but also at <TransactionRow /> time, for the pair asset address, which despite having {enabled: false}, was leveraging the previously cached call
from <AddLiquidityInput /> because of the initial sym type selection in input.
Pull Request Type
[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
Description
This PR includes:
<AddLiquidityInput />time (for legit from address reasons) but also at<TransactionRow />time, for the pair asset address, which despite having{enabled: false}, was leveraging the previously cached call from<AddLiquidityInput />because of the initial sym type selection in input.Pull Request Type
Issue (if applicable)
N/A, fast follow on https://github.com/shapeshift/web/pull/6800 targeted to bugs spotted in release
Risk
Low/Medium, though this mostly brings safety so in effect should really be low.
Interactions with THORChain LP, ensuring we do not use pair addresses for non-sym deposits.
Testing
Engineering
Operations
Screenshots (if applicable)