Closed 0xApotheosis closed 2 weeks ago
Fixes regression in https://github.com/shapeshift/web/pull/6755 where undefined was present in the memo for savers withdraws and deposits, which cannot be parsed by THORChain.
undefined
N/A
High Risk PRs Require 2 approvals
Theoretically high as it touches memos, but practically low as it fixes a known issue.
What protocols, transaction types or contract interactions might be affected by this PR?
Thorchain savers deposits and withdraw.
Complete a savers deposit or withdraw and confirm that the minOut field of the memo is an empty string and not undefined.
minOut
☝️
Description
Fixes regression in https://github.com/shapeshift/web/pull/6755 where
undefinedwas present in the memo for savers withdraws and deposits, which cannot be parsed by THORChain.Pull Request Type
Issue (if applicable)
N/A
Risk
Theoretically high as it touches memos, but practically low as it fixes a known issue.
Thorchain savers deposits and withdraw.
Testing
Complete a savers deposit or withdraw and confirm that the
minOutfield of the memo is an empty string and notundefined.Engineering
☝️
Operations
☝️
Screenshots (if applicable)
N/A