Handle multiple Ledgers and account management

woodenfurniture commented 7 months ago

Overview

The ledger device ID is the same for every device, meaning query cache using wallet deviceId will be invalid if a different ledger is connected.

References and additional details

Originally noted here : https://github.com/shapeshift/web/pull/6780#discussion_r1588979619

Acceptance Criteria

Account management operates as intended across different ledger devices for all states and user flows.

SPIKE:

can we auto open (and close / re-open) apps on ledger devices
if so, this can be implemented in both connection / pairing flow and also to confirm device identity
if not, lazy check of device identity on next wallet interaction (confirming account 0 matches expected account 0). If doesn't match prompt user. If match no action, proceed.

research #1 and create needed follow up tickets for 2 and 3 depending on out come.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

woodenfurniture commented 6 months ago

Ledger does not ship with a uniquely identifiable serial number on the device - they are all 0001 (privacy reasons possibly?).

Regardless, it seems storing account configuration keyed by wallet device ID is not desirable because its possible for a user to wipe their device and reinitialize with totally different seed, which when reconnected would have accountIds configured which do not exist for the device. This may not matter as far as account balances etc, since those accountIds wont be accessible by the device so will not appear in-app (we'd have to verify this is the case), but the configured chainIds that are visible throughout the app would have to check what accounts are actually accessible at runtime so as not to display a chainId for an account that is not longer accessible by the device corresponding to the device ID.

We may want to try one of the following:

simply leave things as-is and let users decide when to hide or show accounts as the connect different wallets. The configured chainIds would then have to check what's accessible by the wallet (which may be slow).
store show/hide accountIds globally ignoring device ID (since device ID is moot as far as ledger is concerned and can be modified with reinit a device), and check available chainIds at runtime (which may be slow).
keep everything as-is and warn ledger users to clear cache if they changed device
always clear configured chainIds for ledger on boot (but keep data per account ID cached for performance)

For reference, this is whats available for a given ledger device:

woodenfurniture commented 6 months ago

To spike:

We can use the first connected account ID for each connected chain to detect if the wallet has changed since the seed it tied to the account derivation.

If the user connects a ledger, ask them to open one of the connectd apps, check the account ID matches, then conditionally proceed or push them into a new connect chains flow.

woodenfurniture commented 6 months ago

Add band-aid text saying something like "Multiple ledger devices are currently not supported, click here to clear your cache" but nicer text
Fast follow with solution

woodenfurniture commented 6 months ago

Relates to https://github.com/shapeshift/web/issues/6970

woodenfurniture commented 3 months ago

can we auto open (and close / re-open) apps on ledger devices

if so, this can be implemented in both connection / pairing flow and also to confirm device identity

if not, lazy check of device identity on next wallet interaction (confirming account 0 matches expected account 0). If doesn't match prompt user. If match no action, proceed.

✅ completed in #7638
❌ not possible
🔄 in progress - https://github.com/shapeshift/web/pull/7639 fixes the trade page. We need this on the remaining pages

woodenfurniture commented 2 months ago

Remaining work - implement #7639 on other pages

shapeshift / web