shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
164 stars 179 forks source link

Thorchain lending slippage levels #6836

Open 0xean opened 4 months ago

0xean commented 4 months ago

ticket replacing this one https://github.com/shapeshift/web/issues/6577

NeOMakinG commented 2 months ago

@shapeshift/product

What I did on LP:

image image

If it's something else than Available, it will display Halted with a red tag

I also added the fact that we display every pools we support even if the status is halted, here is a monkey patched example:

image

It actually doesn't change anything and will almost never be shown as loan_collateral will mostly be 0, we actually end up with BTC and ETH pool for now but it works!

Pools: We already handle the status: image

BorrowInput: we already handle the slippage Acknowledge warning RepayInput: Missing the slippage acknowledge warning, I'll add it in the same PR

Do I miss anything regarding heuristics? Is that enough?

twblack88 commented 2 months ago

Sounds right. It's that tag, e.g., if a lending pool is at capacity it shouldn't show as healthy.

It should say active probably.

Screenshot 2024-06-19 at 3 42 00 PM

NeOMakinG commented 2 months ago

If someone has a loan to repay or can deposit in the LP at one time because it's a bit emptier, feel free to finish this but it's pretty hard to test on my side for now

0xean commented 1 week ago

potentially closing based on upcoming TC vote