search

shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
157 stars 180 forks source link

fix: undefined hiddenAccountIds on init #6840

Closed 0xApotheosis closed 1 month ago

0xApotheosis commented 1 month ago

Description

Fix undefined hiddenAccountIds on app load, which is crashing the app.

Screenshot 2024-05-07 at 1 20 51 PM Screenshot 2024-05-07 at 1 11 51 PM

Pull Request Type

Issue (if applicable)

N/A - currently in develop, which presents when the account management feature flag is on.

Risk

High Risk PRs Require 2 approvals

Small

What protocols, transaction types or contract interactions might be affected by this PR?

N/A

Testing

Loading the app with the account management feature flag on should be great again.

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

See description.

0xApotheosis commented 1 month ago

Killing this PR, no actual user will encounter this issue - devs only during reviews!

woodenfurniture commented 1 month ago

This ended up being cherry-picked into #6819 6819