search

shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
159 stars 180 forks source link

Intermittent failure to import accounts in account import drawer #6928

Closed woodenfurniture closed 1 week ago

woodenfurniture commented 2 weeks ago

Overview

There's a intermittent issue importing accounts. See details below.

References and additional details

See comments at 0:45 and 0:50 in the jam: https://jam.dev/c/28e42ad1-da47-4164-b593-64219561203a

Originally raised in: https://github.com/shapeshift/web/pull/6908#pullrequestreview-2054586834

Acceptance Criteria

Accounts reliably load without failure.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

woodenfurniture commented 2 weeks ago

@gomesalexandre does this relate to your fix in https://github.com/shapeshift/web/pull/6827 ?

gomesalexandre commented 2 weeks ago

@gomesalexandre does this relate to your fix in #6827 ?

Probably isn't, IIRC those failures weren't exclusive to UTXOs - going to give this another retest now that #6827 is in we should be on a sane base WRT UTXOs scriptTypes to fix this so let's wait before #6827 gets in and test this again.

woodenfurniture commented 2 weeks ago

Non-blocking for initial release