feat: add base support - Githubissues

kaladinlight commented 2 weeks ago

Description

Add basic support for base blockchain. (Send/Receive, Balances, Transaction History, Balance History).

This does not include swap support, nft support, or on ramps

~~Pending: https://github.com/shapeshift/hdwallet/pull/672~~

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes https://github.com/shapeshift/web/issues/6833

Risk

High Risk PRs Require 2 approvals

Low - does not change any existing behavior and is behind a feature flag

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Ensure you can send transactions (native and token - supported wallets)
Ensure new transactions are detected over websocket (pending and confirmed)
Ensure balances and transaction history are accurate
Ensure network/assets are displayed correctly
Ensure market data is accurate

Engineering

Operations

Screenshots (if applicable)

0xApotheosis commented 1 week ago

Been debugging this too @gomesalexandre - some additional info that might help:

I'm getting the infinite fetching loop only on MetaMask (no Snap). Native is working fine.
The state seems to get corrupted - e.g. if I switch back to develop I'm still in an infinite loop (though a fresh cache gets it working again)

kaladinlight commented 1 week ago

First pass - noticed accounts are in an infinite fetching loop after a full cache clear, which isn't the case on develop https://jam.dev/c/785810ab-12f6-4b28-b424-1bb344a48595

This is caused by shapeshift/hdwallet#671 (which isn't present in develop currently since we didn't merge its web fren #6827) which this PR includes. Its web fren actually fixes the infinite loop issue - when the multichain snap isn't installed, trying to derive an account 0+ always derive the same account 0 pubkey (which has activity) meaning we fetch the "next" account number (really 0th) again ad vitam aeternam.

@kaladinlight, ideally #6889 needs to go in before but alternatively, if we don't want this to go first, we can also cherry-pick the <AppContext /> bits separately here.

All of the second pass testing below has been done after merging #6889 locally.

Derp, good catch and will work on getting #6889 in first with this to follow.

shapeshift / web

feat: add base support #6933