shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
164 stars 179 forks source link

Portals - Market Data #7305

Closed gomesalexandre closed 1 month ago

gomesalexandre commented 2 months ago

Overview

See this comment: https://github.com/shapeshift/web/issues/6981#issuecomment-2206869446

  1. What about market-data?

Historical market data isn't going to be available, but that's nothing different than e.g how we used to do UNI-V2 opportunities - we absolutely can and should upsert the current price of all https://api.portals.fi/v2/tokens tokens in the market-data slice

References and additional details

https://api.portals.fi/v2/tokens which contains spot price

Acceptance Criteria

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

0xean commented 2 months ago

discussion from grooming on monday: provider vs JIT - JIT much less LOE but not reusable for showing in portfolio / defi positions

@0xApotheosis should have this work done in the custome import token implementation and we can use that for learnings to apply here.

0xean commented 2 months ago

estimates are based on JIT approach, we can improve as we know more

0xean commented 1 month ago

@0xApotheosis working on implementation w custom tokens that can also be leveraged for this

suhailgme commented 1 month ago

fyi @gomesalexandre historical data is now available https://api.portals.fi/docs#/Supported/SupportedController_getTokenHistory