shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
164 stars 179 forks source link

Trade modal via accounts page does not reflect selected asset #7316

Closed purelycrickets closed 2 weeks ago

purelycrickets commented 2 months ago

Overview

Currently in Production, the trade modal is always ETH to FOX no matter what coin is selected when visiting from the trade page. From the asset page, the trade modal is ETH into the asset you are viewing. The Accounts page has the same logic as the trade page currently and displays ETH > FOX, this does not change like it does in the assets page to mirror the selected asset by the user

References and additional details

image-8 Image of ETH> FOX in the trade modal while navigating the Cosmos account page^

Acceptance Criteria

If desired, the accounts page trade modal logic should match the same logic as the asset page.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

reallybeard commented 1 month ago

This seems pretty straight forward, the asset should reflect the current page you are one either account or asset page.

0xean commented 1 month ago

@purelycrickets - can you repro and help with steps to do it / jam it?

seems like works correctly on happy path

0xean commented 1 month ago

https://app.shapeshift.com/#/wallet/accounts/cosmos:cosmoshub-4:cosmos1k0q3reyg3q5as0uu4xy0ptfnynjrspw70vwyd7/cosmos:cosmoshub-4%2Fslip44:118

repro'd using the wallet page as linked above