shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
163 stars 180 forks source link

Ledger trades stuck at signing when app not opened prior #7339

Open woodenfurniture opened 2 weeks ago

woodenfurniture commented 2 weeks ago

Overview

If the user does not have the relevant ledger app open on the device at the time of tx signing, the app spins infinitely until the user goes back.

The app should disable the "sign transaction" button until the ledger app is open. Additionally there should be some sort of prompt to let the user know to open the relevant app on the device, like account management does.

References and additional details

Infinite spinner when opening bitcoin app after clicking "sign transaction"

image

Acceptance Criteria

Should be impossible to get into a state where a transaction is stuck due to ledger app not being open at the time of signing.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

woodenfurniture commented 2 weeks ago

@shapeshift/product tagged at needs product for UX details on flow

twblack88 commented 1 week ago

Acknowledgement trigger probably is best here. Both screens maybe?

info variant though.

reallybeard commented 1 week ago

@woodenfurniture what do you think about this:

If we detect the ledger app is not open, we should disable the sign transaction button. And pop open the ACK for connecting to the app on ledger.

Here is an example of this would look, very similar to the account management flow.

Screenshot 2024-07-11 at 4 57 41 PM

We should handle the same toast that we do on account management, if they click next and there is no app detected fire that same toast message.

Screenshot 2024-07-11 at 4 45 32 PM

0xean commented 1 week ago

related to #7374

reallybeard commented 5 days ago

@shapeshift/product talked it over with @woodenfurniture and we decided the easiest way to get this done was to pop this open in a modal instead of the ack. Which I think totally works in the case.