Unable to deposit in LPs

MBMaria commented 2 months ago

Overview

trying to deposit into LPs just spins/loads continuously

References and additional details

https://jam.dev/c/2daab18f-dd49-4a48-a63e-15c223a75662

Acceptance Criteria

Should be able to deposit into LP

Need By Date

No response

Screenshots/Mockups

No response

Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

0xApotheosis commented 2 months ago

I suspect the cause of this is the unpredictable gas limit:

MBMaria commented 2 months ago

this is on chrome too, btw

gomesalexandre commented 2 months ago

Tenderly run: https://www.tdly.co/shared/simulation/195511ab-3f60-4210-b605-0bf450a7943e

This is with the same args as with the estimate call in the Jam, only with the expiry modified to a later time, as the contract call would otherwise revert as quote expired.

As can be seen above, the reason behind those estimate failures is allowance not yet granted... Though that would only happen for EVM chains, not DOGE as noted above and we should handle this gracefully either way (i.e fire a request either for approval Tx or akschual Tx) so I suspect there's something else going on here.

kaladinlight commented 2 months ago

shapeshift / web