Difference in fee stated on ShapeShift vs MM pop up

MBMaria commented 3 days ago

Overview

When looking at the fee ShapeShift quotes for a trade, it is less than what it stated on the MM pop up window. For one trade I completed just now, the fee ended up being about in the middle

References and additional details

https://jam.dev/c/7d461c3f-df6c-4be5-bbc6-f60e00e244e0

Acceptance Criteria

Fee should be the same or similar stated on ShapeShift and MM

Need By Date

No response

Screenshots/Mockups

No response

Ownership

[X] If my bounty needs engineering or needs product I have added the respective labels on the right
[X] As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

Join our discord
Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
Please refer to this link for some basic info
Please do not start work on this issue until you are approved in Gitcoin.

gomesalexandre commented 3 days ago

FYI this isn't only MM/ShapeShift specific, noted the same with MM connected to e.g Jumper and other DeFi dApps over the last days (e.g trades quoted at ~$10 gas in dApp but $30+ in MM. @kaladinlight may have some context WRT those discrepancies?

woodenfurniture commented 2 days ago

Would be interesting to compare the ETH amount of the fee in case its a fiat pricing issue on ours/metamask side.

May be related to #7295 in such case we will need periodic re-estimation to keep the fees roughly accurate.

shapeshift / web