shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
172 stars 185 forks source link

fix: amounts checks on swapper #8106

Closed NeOMakinG closed 2 weeks ago

NeOMakinG commented 2 weeks ago

Description

Rates are not properly checking the balances/amounts/fees deductions, introduced by https://github.com/shapeshift/web/commit/d8c2efeb5d3248e133cb70abd6c1df9d78de2e52#diff-11cff69592f70893ba71b1f145ba4691cf7452b1c8188088b9769e13fd055ed9R257-R282

As It's a wip, seen in private with gomes, we can remove these checks to fix those check and avoid letting a bug in production while the work is on going.

Issue (if applicable)

closes #8103

Risk

Low because revert medium because swapper

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Engineering

n/a

Operations

n/a

Screenshots (if applicable)

image