shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
175 stars 188 forks source link

feat: hide native assets in asset selection modals for limit orders #8121

Closed woodenfurniture closed 5 days ago

woodenfurniture commented 1 week ago

Description

Hides native assets in asset selection for limit orders, as native assets are not supported.

Fixes 2 production bugs:

Issue (if applicable)

closes #6203

Risk

High Risk PRs Require 2 approvals

Moderate risk as this makes some minor refactors of the trade asset selection components.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Thoroughly test asset selection, focusing on trade input and less so on limit orders - trades are user facing and limit orders are behind a feature flag.

Spot Trade

Limit order

Engineering

Operations

Screenshots (if applicable)

Native assets hidden for limit order asset selection:

[phantom wallet] Solana should not appear in the list of assets or chains Prod:

This PR:

Chains for the "buy" asset which not supported by the wallet should appear in the chain drop-down on the right. Prod:

This PR: