i.e those limitations are perfectly fine for Bitcoin as we will never overflow them, but for e.g DOGE, it's pretty easy to end up in situation with outputs for which the value
is greater than MAX_SAFE_INTEGER (but lower than MAX_VALUE).
This removes the check to unbork things for that user.
What protocols, transaction types, wallets or contract interactions might be affected by this PR?
Very high - for those high-value Txs, things could overflow. If any output Tx is malformed, this could end up in either receiving less than attempted, getting less change than expected, or a mix of both, with the network being gifted the overflown mistake.
Testing
@kaladinlight to confirm removal is sane
regular UTXO sends with smol amounts are still happy
Engineering
^
Operations
[ ] :checkered_flag: My feature is behind a flag and doesn't require operations testing (yet)
Description
i.e those limitations are perfectly fine for Bitcoin as we will never overflow them, but for e.g DOGE, it's pretty easy to end up in situation with outputs for which the value is greater than MAX_SAFE_INTEGER (but lower than MAX_VALUE).
This removes the check to unbork things for that user.
Issue (if applicable)
closes https://github.com/shapeshift/web/issues/8128
Risk
Very high - for those high-value Txs, things could overflow. If any output Tx is malformed, this could end up in either receiving less than attempted, getting less change than expected, or a mix of both, with the network being gifted the overflown mistake.
Testing
Engineering
Operations
Screenshots (if applicable)