shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
172 stars 185 forks source link

fix: fox discount ux #8136

Closed 0xApotheosis closed 3 days ago

0xApotheosis commented 4 days ago

Description

On the fox route:

Issue (if applicable)

Closes https://github.com/shapeshift/web/issues/8123

Risk

Small (UI changes only)

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None

Testing

Screenshot 2024-11-18 at 07 49 05

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

See testing step.

0xApotheosis commented 3 days ago

@NeOMakinG does the 480 FOX come from another EVM at the same address, or from a different previously connected wallet?

Assume it's the former, and agree it could be confusing - that said, if a user has FOX on another chain they are probably a power-ish user and would likely understand this to some degree.

NeOMakinG commented 3 days ago

@NeOMakinG does the 480 FOX come from another EVM at the same address, or from a different previously connected wallet?

Assume it's the former, and agree it could be confusing - that said, if a user has FOX on another chain they are probably a power-ish user and would likely understand this to some degree.

I think same address but unsupported chain from our interface with the selected wallet (ex: Arbitrum but using Phantom)

Seems like the snapshot API returns the voting power for every chains and strategies it supports regardless if our interface is currently supporting it