fix: remove related assets and duplicate chains from asset chain dropdown

woodenfurniture commented 1 week ago

Description

Removes WETH as a related asset to ETH such that "related assets" only applies to the same asset on a different chain.

Also includes a change to remove duplicate chains.

Issue (if applicable)

closes #8135

Indirectly resolves and closes #8134 (list of chains is now small enough that the reported issue doesn't occur)

Risk

High Risk PRs Require 2 approvals

Low risk

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

Only chains for the same asset appear in the asset-chain dropdown when selecting an asset, (i.e no WETH for ETH)
No duplicate entries in the drop-down
The menu always fits on the screen, effectively closing #8134

Engineering

The related asset generation script was run to update the related assets .json file completely. Please sanity check this as an approach in case WETH reappears for some unexpected reason.

Operations

[ ] :checkered_flag: My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Prod:

This PR:

woodenfurniture commented 1 week ago

❌ Assets on Ethereum missing from related assets (though I don't see anything in particular from your changes that would have caused this?)

Well spotted, fix and repushed

woodenfurniture commented 6 days ago

WETH is back with the recent rebase:

Looks like it was a cache issue, the cache key has incremented under this PR so you've been given stale cache. I've bumped the key again.

shapeshift / web