shapeshift / web

ShapeShift Web
https://app.shapeshift.com
MIT License
172 stars 185 forks source link

Less invasive rate changed UX #8144

Open gomesalexandre opened 3 days ago

gomesalexandre commented 3 days ago

Overview

Placeholder for @shapeshift/product, raised by @0xApotheosis in https://github.com/shapeshift/web/pull/8079#pullrequestreview-2444202042

image

We should probably show the difference in the rate, maybe as a percentage here. This popped up every time for me when using Portals (maybe because we go from not knowing gas to knowing gas? This itself feels like a bug/undesirable behavior), and every time I had to try work out if the rate got better or worse, but I didn't know because I had no reference point.

Indeed, this does look like a broken flow to have that show up consistently, as rates changing isn't an exception but the regular flow here.

References and additional details

https://github.com/shapeshift/web/pull/8079

Acceptance Criteria

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

0xean commented 1 day ago

https://docs.google.com/spreadsheets/d/1-gjh29Ns8q_IyQuJoUE4xP4e6XEV_n7ks__1_maSMMk/edit?gid=0#gid=0

reallybeard commented 1 day ago

New mockup for the rate changes modal, that shows the difference. https://www.figma.com/design/VSXdqFlFkBhdcPs2WqJqMo/SWAP-UX?node-id=2659-3748&node-type=frame&t=4BI3CTMTWJUIVgKA-0

0xean commented 1 day ago

Per conversation today with team, we are gonna move forward fixing portals and then looking at a threshold based approach. Portals does not allow us to set an absolute number for min out, just a percentage.